Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add french support #168

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

dimon222
Copy link
Member

This is broken, don't bother merging until its working.

@KintonHiryuu
Copy link
Contributor

KintonHiryuu commented Apr 23, 2021

seems like it struggle with systems tho, in Ivara Prime Système Schéma , it read Ivara Prime stèmes Schéma and print out the BP of Ivara - it seems like the only thing it really struggles with tho, everything that's not systems (at least in my prime inventory) seems good

it sometimes print links out of barrels (cannon) for some reason, but at least it reads it correctly

Copy link
Contributor

@KintonHiryuu KintonHiryuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 126 - Regex triggers on é è ê and so on, i updated it to this
[^a-zàâçéèêëîïôûùüÿñæœ() 가-힣]
and it seems to work better, but still not perfectly

note : parentheses and spaces must be in there or it reads absolutely badly every items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants