Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(861n1w5zd): helper text #12

Merged
merged 13 commits into from
Aug 8, 2023
Merged

feat(861n1w5zd): helper text #12

merged 13 commits into from
Aug 8, 2023

Conversation

mateusz-kleszcz
Copy link
Contributor

Add helper text component:

  • add helper textcomponent to storybook
  • handle config
  • write tests
  • handle wrong variants

image

@mateusz-kleszcz mateusz-kleszcz temporarily deployed to development July 20, 2023 09:57 — with GitHub Actions Inactive
@mateusz-kleszcz mateusz-kleszcz temporarily deployed to development July 20, 2023 11:47 — with GitHub Actions Inactive
adrian-potepa
adrian-potepa requested changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconBefore type should be changed

@mateusz-kleszcz mateusz-kleszcz temporarily deployed to development July 27, 2023 11:43 — with GitHub Actions Inactive
@adrian-potepa
Copy link
Collaborator

adrian-potepa commented Jul 28, 2023 •
edited
Loading

image

To mach space between icon and text, should be 4px ;)

adrian-potepa
adrian-potepa requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor fixes.

@mateusz-kleszcz mateusz-kleszcz temporarily deployed to development July 31, 2023 06:47 — with GitHub Actions Inactive
@mateusz-kleszcz mateusz-kleszcz temporarily deployed to development August 8, 2023 06:55 — with GitHub Actions Inactive
@mateusz-kleszcz mateusz-kleszcz merged commit d9acc62 into development Aug 8, 2023
1 check passed
@mateusz-kleszcz mateusz-kleszcz deleted the feat/861n1w5zd/helper-text branch August 8, 2023 12:38
kudyniuk pushed a commit that referenced this pull request Oct 2, 2023
@semantic-release-bot
chore(release): 1.0.0-rc.1 [skip ci]
c563b90 
# 1.0.0-rc.1 (2023-10-02)

### Bug Fixes

* fix medium size in theme ([#9](#9)) ([e690061](e690061))
* NO-JIRA text input onChange behavior ([#44](#44)) ([a267e35](a267e35))
* **storybook:** path to brand logo TET-138 ([#56](#56)) ([dc23158](dc23158))
* TET-191 remove extract margin props util, fix double focus ([#64](#64)) ([e9382f4](e9382f4))
* TET-245 deep clone default config ([#67](#67)) ([ac917ee](ac917ee))

### Features

* **861n1w5zd:** helper text ([#12](#12)) ([d9acc62](d9acc62))
* add checkbox group ([#26](#26)) ([4e5ebda](4e5ebda)), closes [#31](#31)
* add Label ([#13](#13)) ([91cf31f](91cf31f))
* add status dot ([#11](#11)) ([a1885a3](a1885a3))
* divider ([#20](#20)) ([8af17e4](8af17e4))
* setup storybook library ([#2](#2)) ([b14dc94](b14dc94))
* TET-128 custom prop tester ([#30](#30)) ([bc94444](bc94444))
* TET-130 text input hasClearButton ([#33](#33)) ([ea7a3c0](ea7a3c0))
* TET-136 alert banner ([#41](#41)) ([b955fa4](b955fa4))
* TET-137 inline banner ([#46](#46)) ([5b97834](5b97834))
* TET-141 select ([#65](#65)) ([65e1f27](65e1f27))
* tet-196 counter ([#43](#43)) ([709f3ca](709f3ca))
* tet-196 merge custom prop ([#45](#45)) ([dda3aef](dda3aef))
* TET-63 inline message ([#24](#24)) ([234a3e7](234a3e7))
* tet-64 popover ([#37](#37)) ([2eed7bb](2eed7bb))
* TET-65 search input  ([#35](#35)) ([bb92fac](bb92fac))
* TET-66 inline search input ([#38](#38)) ([11483e1](11483e1))
* theme tokens update after figma variables release ([#8](#8)) ([124ce87](124ce87))
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@semantic-release-bot
chore(release): 1.0.0-rc.1 [skip ci]
673c764 
# 1.0.0-rc.1 (2023-10-04)

### Bug Fixes

* fix medium size in theme ([#9](#9)) ([e690061](e690061))
* NO-JIRA text input onChange behavior ([#44](#44)) ([a267e35](a267e35))
* **storybook:** path to brand logo TET-138 ([#56](#56)) ([dc23158](dc23158))
* TET-191 remove extract margin props util, fix double focus ([#64](#64)) ([e9382f4](e9382f4))
* TET-245 deep clone default config ([#67](#67)) ([ac917ee](ac917ee))

### Features

* **861n1w5zd:** helper text ([#12](#12)) ([d9acc62](d9acc62))
* add checkbox group ([#26](#26)) ([4e5ebda](4e5ebda)), closes [#31](#31)
* add Label ([#13](#13)) ([91cf31f](91cf31f))
* add status dot ([#11](#11)) ([a1885a3](a1885a3))
* divider ([#20](#20)) ([8af17e4](8af17e4))
* setup storybook library ([#2](#2)) ([b14dc94](b14dc94))
* TET-128 custom prop tester ([#30](#30)) ([bc94444](bc94444))
* TET-130 text input hasClearButton ([#33](#33)) ([ea7a3c0](ea7a3c0))
* TET-136 alert banner ([#41](#41)) ([b955fa4](b955fa4))
* TET-137 inline banner ([#46](#46)) ([5b97834](5b97834))
* TET-141 select ([#65](#65)) ([65e1f27](65e1f27))
* tet-196 counter ([#43](#43)) ([709f3ca](709f3ca))
* tet-196 merge custom prop ([#45](#45)) ([dda3aef](dda3aef))
* TET-63 inline message ([#24](#24)) ([234a3e7](234a3e7))
* tet-64 popover ([#37](#37)) ([2eed7bb](2eed7bb))
* TET-65 search input  ([#35](#35)) ([bb92fac](bb92fac))
* TET-66 inline search input ([#38](#38)) ([11483e1](11483e1))
* theme tokens update after figma variables release ([#8](#8)) ([124ce87](124ce87))
@adrian-potepa
Copy link
Collaborator

🎉 This PR is included in version 1.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@semantic-release-bot
chore(release): 1.0.0-rc.1 [skip ci]
4e03ea5 
# 1.0.0-rc.1 (2023-10-04)

### Bug Fixes

* fix medium size in theme ([#9](#9)) ([e690061](e690061))
* NO-JIRA text input onChange behavior ([#44](#44)) ([a267e35](a267e35))
* **storybook:** path to brand logo TET-138 ([#56](#56)) ([dc23158](dc23158))
* TET-135 max line length ([#76](#76)) ([286483c](286483c))
* TET-135 semantic release ([#75](#75)) ([fdc9bb6](fdc9bb6))
* TET-191 remove extract margin props util, fix double focus ([#64](#64)) ([e9382f4](e9382f4))
* TET-245 deep clone default config ([#67](#67)) ([ac917ee](ac917ee))

### Features

* **861n1w5zd:** helper text ([#12](#12)) ([d9acc62](d9acc62))
* add checkbox group ([#26](#26)) ([4e5ebda](4e5ebda)), closes [#31](#31)
* add Label ([#13](#13)) ([91cf31f](91cf31f))
* add status dot ([#11](#11)) ([a1885a3](a1885a3))
* divider ([#20](#20)) ([8af17e4](8af17e4))
* setup storybook library ([#2](#2)) ([b14dc94](b14dc94))
* TET-128 custom prop tester ([#30](#30)) ([bc94444](bc94444))
* TET-130 text input hasClearButton ([#33](#33)) ([ea7a3c0](ea7a3c0))
* TET-136 alert banner ([#41](#41)) ([b955fa4](b955fa4))
* TET-137 inline banner ([#46](#46)) ([5b97834](5b97834))
* TET-141 select ([#65](#65)) ([65e1f27](65e1f27))
* tet-196 counter ([#43](#43)) ([709f3ca](709f3ca))
* tet-196 merge custom prop ([#45](#45)) ([dda3aef](dda3aef))
* TET-63 inline message ([#24](#24)) ([234a3e7](234a3e7))
* tet-64 popover ([#37](#37)) ([2eed7bb](2eed7bb))
* TET-65 search input  ([#35](#35)) ([bb92fac](bb92fac))
* TET-66 inline search input ([#38](#38)) ([11483e1](11483e1))
* theme tokens update after figma variables release ([#8](#8)) ([124ce87](124ce87))
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@semantic-release-bot
chore(release): 1.0.0-rc.1 [skip ci]
b966398 
# 1.0.0-rc.1 (2023-10-04)

### Bug Fixes

* fix medium size in theme ([#9](#9)) ([e690061](e690061))
* NO-JIRA text input onChange behavior ([#44](#44)) ([a267e35](a267e35))
* **storybook:** path to brand logo TET-138 ([#56](#56)) ([dc23158](dc23158))
* TET-135 max line length ([#76](#76)) ([286483c](286483c))
* TET-135 semantic release ([#75](#75)) ([fdc9bb6](fdc9bb6))
* TET-191 remove extract margin props util, fix double focus ([#64](#64)) ([e9382f4](e9382f4))
* TET-245 deep clone default config ([#67](#67)) ([ac917ee](ac917ee))

### Features

* **861n1w5zd:** helper text ([#12](#12)) ([d9acc62](d9acc62))
* add checkbox group ([#26](#26)) ([4e5ebda](4e5ebda)), closes [#31](#31)
* add Label ([#13](#13)) ([91cf31f](91cf31f))
* add status dot ([#11](#11)) ([a1885a3](a1885a3))
* divider ([#20](#20)) ([8af17e4](8af17e4))
* setup storybook library ([#2](#2)) ([b14dc94](b14dc94))
* TET-128 custom prop tester ([#30](#30)) ([bc94444](bc94444))
* TET-130 text input hasClearButton ([#33](#33)) ([ea7a3c0](ea7a3c0))
* TET-136 alert banner ([#41](#41)) ([b955fa4](b955fa4))
* TET-137 inline banner ([#46](#46)) ([5b97834](5b97834))
* TET-141 select ([#65](#65)) ([65e1f27](65e1f27))
* tet-196 counter ([#43](#43)) ([709f3ca](709f3ca))
* tet-196 merge custom prop ([#45](#45)) ([dda3aef](dda3aef))
* TET-63 inline message ([#24](#24)) ([234a3e7](234a3e7))
* tet-64 popover ([#37](#37)) ([2eed7bb](2eed7bb))
* TET-65 search input  ([#35](#35)) ([bb92fac](bb92fac))
* TET-66 inline search input ([#38](#38)) ([11483e1](11483e1))
* theme tokens update after figma variables release ([#8](#8)) ([124ce87](124ce87))
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@semantic-release-bot
chore(release): 1.0.0-rc.1 [skip ci]
b283979 
# 1.0.0-rc.1 (2023-10-04)

### Bug Fixes

* fix medium size in theme ([#9](#9)) ([e690061](e690061))
* NO-JIRA text input onChange behavior ([#44](#44)) ([a267e35](a267e35))
* **storybook:** path to brand logo TET-138 ([#56](#56)) ([dc23158](dc23158))
* TET-135 max line length ([#76](#76)) ([286483c](286483c))
* TET-135 semantic release ([#75](#75)) ([fdc9bb6](fdc9bb6))
* TET-191 remove extract margin props util, fix double focus ([#64](#64)) ([e9382f4](e9382f4))
* TET-245 deep clone default config ([#67](#67)) ([ac917ee](ac917ee))

### Features

* **861n1w5zd:** helper text ([#12](#12)) ([d9acc62](d9acc62))
* add checkbox group ([#26](#26)) ([4e5ebda](4e5ebda)), closes [#31](#31)
* add Label ([#13](#13)) ([91cf31f](91cf31f))
* add status dot ([#11](#11)) ([a1885a3](a1885a3))
* divider ([#20](#20)) ([8af17e4](8af17e4))
* setup storybook library ([#2](#2)) ([b14dc94](b14dc94))
* TET-128 custom prop tester ([#30](#30)) ([bc94444](bc94444))
* TET-130 text input hasClearButton ([#33](#33)) ([ea7a3c0](ea7a3c0))
* TET-136 alert banner ([#41](#41)) ([b955fa4](b955fa4))
* TET-137 inline banner ([#46](#46)) ([5b97834](5b97834))
* TET-141 select ([#65](#65)) ([65e1f27](65e1f27))
* tet-196 counter ([#43](#43)) ([709f3ca](709f3ca))
* tet-196 merge custom prop ([#45](#45)) ([dda3aef](dda3aef))
* TET-63 inline message ([#24](#24)) ([234a3e7](234a3e7))
* tet-64 popover ([#37](#37)) ([2eed7bb](2eed7bb))
* TET-65 search input  ([#35](#35)) ([bb92fac](bb92fac))
* TET-66 inline search input ([#38](#38)) ([11483e1](11483e1))
* theme tokens update after figma variables release ([#8](#8)) ([124ce87](124ce87))
This was referenced Oct 6, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-potepa adrian-potepa adrian-potepa approved these changes

@mwleklinski mwleklinski mwleklinski approved these changes

Assignees
No one assigned
Labels
released on @release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateusz-kleszcz @adrian-potepa @mwleklinski