Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Vesktop icon #865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: New Vesktop icon #865

wants to merge 2 commits into from

Conversation

Covkie
Copy link
Collaborator

@Covkie Covkie commented Sep 19, 2024

feedback welcome.

Also cleaned up icons and removed dynamically setting the icon (electron builder handles this).

raw svg:
vesktop

Covkie and others added 2 commits September 19, 2024 19:17
feedback welcome.

Also cleaned up icons and removed dynamically setting the icon (electron builder handles this)
@Mikilio
Copy link

Mikilio commented Sep 21, 2024

I just randomly appeared here. I quite like the design, but the background colors trip me up a bit (in particular the darker lighter square on the lighter circle. There can also be a discussion made about how the details actually look on small icons, so maybe some details can be removed in favor of making the outlines pop more using contrast. (In particular, the amount of hairpins and the "VC" look very noisy on the composition.)
You split the colors of the background diagonally, but maybe you may want to keep them a single color and have an Icon for light mode and one for dark mode.

Even without any changes, I'd be happy to see this on my Vesktop client, though.

@x0rp01s0n

This comment was marked as spam.

@Covkie
Copy link
Collaborator Author

Covkie commented Oct 12, 2024

@Mikilio

but the background colors trip me up a bit (in particular the darker lighter square on the lighter circle

That is the raw svg which I included for future modifications. The actual in use icons are the .svg .ico and .icns under the build directory. https://github.com/Vencord/Vesktop/pull/865/files

Here's a preview:
svg_ico
icns

@Pukimaa

This comment was marked as spam.

@Mikilio
Copy link

Mikilio commented Nov 2, 2024

So what are the steps to merging this? Will there be a vote, or who gets to decide? With these, it's always hard to call it a objective improvement.

@Covkie
Copy link
Collaborator Author

Covkie commented Nov 2, 2024

design was discussed on the discord. it will be merged when its merged.

@dphaldes
Copy link

dphaldes commented Nov 9, 2024

Could the same icon be used for the system tray (atleast on linux) ?

@Covkie
Copy link
Collaborator Author

Covkie commented Dec 9, 2024

Is there a reason this patch does not use the new Vesktop icon as the Windows app icon?

it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants