feat: Allow tray icon customization #576
Conversation
|
wow looks really good so far especially for a first contribution! i'm not sure about the ui though, it would probably be much better to actually show the image that is chosen and maybe have it so you can click the image to change it? something like the profile picture picker (but way more simplistic) also i can see a bit of inconsistent formatting, make sure you have prettier properly configured! |
|
I had some issues with displaying an image from the local filesystem on the Vesktop settings page. I ended up moving the tray icon setting to a tray icon context menu item, where I think it makes more sense to be. (old method kept on a branch in case this ends up being worse)
When selected, it brings up this window which has the same functionality as the setting did before while also showing the current icon. This could probably use some additional formatting to make it look better.
|
|
Many thanks for your PR! To be honest, I don't think an option as "important" as this should be so easily accessible with via right-click. Vendicated's idea ends up fitting better (of displaying the icon on the settings page next to the "Tray Icon" option, instead of your idea of adding new buttons). |
That's my end goal too, I just shied away due to literally never having used css or html. After much learning (read: pain), the recent commits moved it back to being in the Vesktop settings menu, with a better UI:
When hovered (test icon shown):
Currently the edit icon image is a hard link to a discord attachment which I don't think are permanent links anymore. Unsure if I should store the icon somewhere in the project itself or try and find a permanent URL for it. |
|
Played around with it under Arch with KDE Plasma, working mighty fine with the exception of a missing edit icon. |
I tried doing this earlier, but Electron's NativeImage (which Tray uses) can only create images from .png and .jpg files. (RIP GIF tray icons) |
|
To the author of this PR: could you test if this also changes the icon when pressing alt+tab? (In KDE, there is the Vencord icon when you press alt+tab.) |
On KDE I can override the icon used in the task switcher by:
Sorry this might seem kind of long/complicated, but it's actually pretty straightforward once you do it |
|
@rootiest Thank you very much! I knew KDE had these special properties, but I didn't know it reached this level of customization! And, in fact, it's pretty straightforward to do this (just like you said). Have a wonderful day, my friend! |
|
It might be worth adding an option to use the favicon the discord website sends, because this dynamically updates the number of pings for just about any number. We do this in armcord, if you would like to see a working example. |
|
awesome work, was looking for this, any progress on this edit: seems like its already merged, why cant i see the feature in vesktop settings ? |
Added option in Vesktop settings to select a custom tray icon, resolves #571
Only tested on Fedora 40 KDE. May need additional testing on Windows, I don't currently have access to a Windows device right now.