Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename classes to prevent conflicts with tailwindcss/user-defined classes #53

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Rename classes to prevent conflicts with tailwindcss/user-defined classes #53

merged 2 commits into from
Jun 19, 2024

Conversation

btglr
Copy link
Contributor

@btglr btglr commented May 19, 2024

Classes like container and grid are fairly common class names already used by CSS frameworks. I've renamed them using a prefix to prevent conflicts.

@ValentinH ValentinH force-pushed the isolate_css_selectors branch from 2e3546d to c14e0cf Compare June 19, 2024 20:23
@ValentinH
Copy link
Owner

Thanks for this.
I renamed the prefix to be svelte-easy-crop to be even more explicit. I'm going to push a new major version in case someone was relying on the classes to override the styles.

@ValentinH ValentinH merged commit 84c78d6 into ValentinH:main Jun 19, 2024
3 checks passed
@ValentinH
Copy link
Owner

https://github.com/ValentinH/svelte-easy-crop/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinH ValentinH ValentinH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btglr @ValentinH