Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix generating screenshots names #7752

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 14, 2024


  • e2e-тесты

Описание

После PR #7728 скриншоты генерируются и проверяются только для light colorSheme. Так происходит из-за неправильно прокинутого значения свойства.

Изменения

Поправил именование свойства colorScheme на colorSchemeType. Использовано это имя так как colorScheme уже есть в playwright

Release notes

Copy link
Contributor

github-actions bot commented Oct 14, 2024

size-limit report 📦

Path Size
JS 386.27 KB (0%)
JS (gzip) 116.87 KB (0%)
JS (brotli) 95.97 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.26 KB (0%)
CSS (gzip) 41.77 KB (0%)
CSS (brotli) 33.1 KB (0%)

Copy link

codesandbox-ci bot commented Oct 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 14, 2024

👀 Docs deployed

Commit 57624c9

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (be5ef3e) to head (57624c9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7752   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11354    11354           
  Branches     3724     3724           
=======================================
  Hits        10803    10803           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft October 14, 2024 17:52
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review October 15, 2024 06:41
@EldarMuhamethanov EldarMuhamethanov merged commit 975878d into master Oct 15, 2024
50 of 52 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-screenshots-names-generating branch October 15, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants