Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Separator): add direction, size, padding and align props #7720

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Oct 7, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Синхронизируемся с дизайном в плане пропов

Изменения

  • селектор .withGaps > * во Flex был утяжелен, потому что мы задаем некоторым компонентам margin, а значение у Flex должно быть приоритетным
  • вынесены общие отступы у компонентов Spacing и Separator

Release notes

BREAKING CHANGE

  • Separator: свойство wide заменено свойством padding

    <Separator
    -  wide={false}
    +  padding
    />
    <Separator
    -  wide
    />
    <Separator
    -  wide={true}
    />

Улучшения

  • Separator: добавлены новые свойства direction, size и align

@BlackySoul BlackySoul requested a review from a team as a code owner October 7, 2024 19:09
@BlackySoul BlackySoul linked an issue Oct 7, 2024 that may be closed by this pull request
@BlackySoul BlackySoul marked this pull request as draft October 7, 2024 19:09
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size
JS 386.19 KB (+0.12% 🔺)
JS (gzip) 116.85 KB (+0.1% 🔺)
JS (brotli) 95.97 KB (+0.01% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.77 KB (+0.31% 🔺)
CSS (gzip) 41.73 KB (+0.38% 🔺)
CSS (brotli) 33.07 KB (+0.35% 🔺)

Copy link

codesandbox-ci bot commented Oct 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 7, 2024

👀 Docs deployed

Commit 0fbbfb8

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (a82b967) to head (0fbbfb8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7720   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         383      384    +1     
  Lines       11343    11355   +12     
  Branches     3718     3725    +7     
=======================================
+ Hits        10792    10804   +12     
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as ready for review October 8, 2024 05:41
packages/vkui/src/components/Separator/Readme.md Outdated Show resolved Hide resolved
packages/vkui/src/components/Separator/Readme.md Outdated Show resolved Hide resolved
packages/vkui/src/components/Spacing/Readme.md Outdated Show resolved Hide resolved
packages/vkui/src/components/Spacing/Readme.md Outdated Show resolved Hide resolved
@BlackySoul BlackySoul force-pushed the feat/5636/Separator_add_vertical branch from 1773eca to 4dfb2f5 Compare October 8, 2024 14:22
@BlackySoul BlackySoul changed the title feat(Separator): add direction, size and align props feat(Separator): add direction, size, padding and align props Oct 8, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨
✨💖✨
✨✨✨

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно 💯 🥇

@BlackySoul BlackySoul merged commit 6039bdc into master Oct 11, 2024
28 checks passed
@BlackySoul BlackySoul deleted the feat/5636/Separator_add_vertical branch October 11, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Separator]: Вертикальный режим Sepatator
3 participants