Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests ids props for Calendar, CalendarRange, DateInputRange, DateInput #7705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Release notes

Описание

Нужно добавить прокидывание тестовых айдишников для важных для тестирования элементов. Это нужно сделать для компонентов CalendarDay, CalendarDays, Calendar, CalendarHeader, CalendarRange, DateInput, DateRangeInput

Изменения

  • Добавил необходимые свойства с id для тестов для прокидывания до всех интерактивных компонентов в Calendar и CalendarRange
  • Переписал тесты для компонентов с использованием новых свойств

Release notes

Улучшения

  • Calendar: Добавлены свойства для установки data-testid у вложенных элементов
  • CalendarRange: Добавлены свойства для установки data-testid у вложенных элементов
  • DateInput: Добавлены свойства для установки data-testid у вложенных элементов
  • DateRangeInput: Добавлены свойства для установки data-testid у вложенных элементов

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 4, 2024 16:42
Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
JS 387.32 KB (+0.42% 🔺)
JS (gzip) 117.12 KB (+0.34% 🔺)
JS (brotli) 96.16 KB (+0.45% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.74 KB (0%)
CSS (gzip) 41.58 KB (0%)
CSS (brotli) 32.95 KB (0%)

Copy link

codesandbox-ci bot commented Oct 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 4, 2024

👀 Docs deployed

Commit 7da9386

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (6b5a24f) to head (7da9386).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7705      +/-   ##
==========================================
- Coverage   95.14%   95.13%   -0.01%     
==========================================
  Files         383      383              
  Lines       11343    11352       +9     
  Branches     3718     3727       +9     
==========================================
+ Hits        10792    10800       +8     
- Misses        551      552       +1     
Flag Coverage Δ
unittests 95.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants