feat(EllipsisText): add title attribute #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 308fdda |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7681 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 383 383
Lines 11335 11339 +4
Branches 3714 3717 +3
=======================================
+ Hits 10787 10791 +4
Misses 548 548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
previously approved these changes
Sep 30, 2024
inomdzhon
reviewed
Sep 30, 2024
packages/vkui/src/components/Typography/EllipsisText/EllipsisText.tsx
Outdated
Show resolved
Hide resolved
packages/vkui/src/components/Typography/EllipsisText/EllipsisText.module.css
Show resolved
Hide resolved
inomdzhon
approved these changes
Sep 30, 2024
andrey-medvedev-vk
approved these changes
Oct 1, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7636/add-text-ellipsis-title
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Необходимо добавить установку аттрибута
titleдля компонентаEllipsisTextс полным текстомИзменения
titleдля компонентаEllipsisTextdisableNativeTitleдля отключения отображения нативного тултипа, на случай, если пользователь захочет добавить отображение настоящего тултипа поверхEllipsisTextRelease notes
Улучшения
title, который отображает весь текст переданный в компонент. Его также можно отключить передав параметрdisableNativeTitle