Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dev-deps): Bump css-loader from 6.10.0 to 7.1.2 #7668

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

inomdzhon
Copy link
Contributor


  • Документация фичи
  • Release notes
  • Тест
    • Сравнил packages/vkui/dist/ в master и в imirdzhamolov/issue6805/tech/css-loader-v7 – без изменений
    • Локально проверил0 документации Styleguide и Storybook – стили не поехали

Описание

С v7.0.0 по умолчанию используется именованный экспорт CSS-модулей, поэтому отключил это поведение через опцию namedExport: false (см. подробнее в релиз ноуте https://github.com/webpack-contrib/css-loader/blob/v7.1.0/CHANGELOG.md). Расширил документацию styleguide/pages/css_modules.md на эту тему.

Также, для подстраховки, явно выставил modules: false там, где не нужны CSS-модули.

Release notes

Документация

  • Раздел CSS Modules дополнен информацией про использование пакета с 'css-loader' >= 7.0.0.

С `v7.0.0` по умолчанию используется именованный экспорт CSS-модулей, поэтому
отключил это поведение через опцию `namedExport: false` (см. подробнее в релиз ноуте https://github.com/webpack-contrib/css-loader/blob/v7.1.0/CHANGELOG.md).

Расширил документацию `styleguide/pages/css_modules.md` на эту тему.

Также, для подстраховки, явно выставил `modules: false` там, где не нужны CSS-модули.
@inomdzhon inomdzhon requested a review from a team as a code owner September 26, 2024 16:01
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 385.32 KB (0%)
JS (gzip) 116.61 KB (0%)
JS (brotli) 95.78 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.15 KB (0%)
CSS (gzip) 41.51 KB (0%)
CSS (brotli) 32.9 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit afca293

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (4b12821) to head (afca293).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7668   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         383      383           
  Lines       11333    11333           
  Branches     3714     3714           
=======================================
  Hits        10785    10785           
  Misses        548      548           
Flag Coverage Δ
unittests 95.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit e99709d into master Sep 27, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue6805/tech/css-loader-v7 branch September 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: обновить css-loader до ^7.0.0
3 participants