feat(Button): update button background-color with appearance="overlay" and mode="secondary" #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" and mode="secondary"
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 34e6065 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7661 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 383 383
Lines 11333 11333
Branches 3714 3714
=======================================
Hits 10785 10785
Misses 548 548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
previously approved these changes
Sep 26, 2024
|
Нужно подтянуть |
…y-overlay-styles # Conflicts: # packages/vkui/src/components/Button/Button.module.css
andrey-medvedev-vk
approved these changes
Sep 27, 2024
inomdzhon
approved these changes
Sep 27, 2024
я не думаю, что она особо нужна, так как сами кнопки на подложке будут выглядеть также |
EldarMuhamethanov
deleted the
e.muhamethanov/7659/change-button-secondary-overlay-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Компонент Button со значениями
appearance="overlay"иmode="secondary"выглядит непредсказуемо на фотографиях, поэтому нужно заменить токены фона в обычном, ховер и active состоянииИзменения
appearance="overlay"иmode="secondary"на--vkui--color_overlay_primary,--vkui--color_overlay_primary--hover,--vkui--color_overlay_primary--active.Release notes
BREAKING CHANGE
appearance="overlay"иmode="secondary"