fix: under-counting metrics for enum is_enabled() #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rbtcollins
commented
Mar 18, 2024
rbtcollins
commented
- fix: under-counting metrics for enum is_enabled()
- Release
Not sure how long this has been broken, but it was : the early exit bypassed the counting of selected result.
rbtcollins
changed the title
|
I figured out - this was a regression in 26eaac3 (@thomasheartman ) |
|
Oh, wow. Good catch! Might be worth adding some tests for it so that we avoid it happening again? |
|
I think the str case is already tested, this is oversight indeed; we should add some tests; it may be a bit before I have time to do that myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.