Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example scripts #2208

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Conversation

Foxglove144
Copy link
Contributor

@Foxglove144 Foxglove144 commented Jun 29, 2023

Description

  1. In adversarial_training_FBF.py, added correct import statement for PyTorchClassifier.
  2. In adversarial_training_data_augmentation.py, disabled TensorFlow eager execution.
  3. In get_started_xgboost.py, added correct eval_metric parameters.
  4. In mnist_cnn_fgsm.py, disabled TensorFlow eager execution and demonstrate FGSM over multiple epsilon values.
  5. In mnist_poison_detection.py, disabled TensorFlow eager execution.
  6. In mnist_transferability.py, disabled TensorFlow eager execution.
  7. In get_started_lightgbm.py, set force_row_wise=true in params to remove the overhead.

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #2208 (92ffe0a) into main (bc39091) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2208   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files         308      308           
  Lines       27448    27448           
  Branches     5044     5044           
=======================================
  Hits        23502    23502           
  Misses       2667     2667           
  Partials     1279     1279           

@beat-buesser beat-buesser self-requested a review June 30, 2023 13:40
@beat-buesser beat-buesser self-assigned this Jun 30, 2023
@beat-buesser beat-buesser added the improvement Improve implementation label Jun 30, 2023
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Foxglove144 Thank you very much for updating the example scripts1

@beat-buesser beat-buesser merged commit c5c6012 into Trusted-AI:main Jul 4, 2023
37 checks passed
@Foxglove144 Foxglove144 deleted the new_branch branch July 4, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants