Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_started_keras.py, adversarial_training_cifar10.py #2188

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Foxglove144
Copy link
Contributor

@Foxglove144 Foxglove144 commented Jun 13, 2023

Description

  1. Fix AttributeError: 'Adam' object has no attribute 'get_updates' in get_started_keras.py
  2. Disable Tensorflow eager execution in adversarial_training_cifar10.py

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Foxglove144 Foxglove144 changed the title Update get_started_keras.py Update get_started_keras.py, adversarial_training_cifar10.py Jun 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #2188 (d86f158) into main (4a317e8) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2188   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         297      297           
  Lines       26520    26520           
  Branches     4864     4864           
=======================================
  Hits        22711    22711           
  Misses       2571     2571           
  Partials     1238     1238           

@beat-buesser beat-buesser self-requested a review June 13, 2023 21:47
@beat-buesser beat-buesser self-assigned this Jun 13, 2023
@beat-buesser beat-buesser added the improvement Improve implementation label Jun 13, 2023
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Foxglove144 Thank you very much for your pull request and updating the examples of ART!

@beat-buesser beat-buesser merged commit d68eec0 into Trusted-AI:main Jun 13, 2023
@Foxglove144 Foxglove144 deleted the new_branch branch June 14, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants