Feature / enable&disable duration #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronsumer.go
Outdated
| @@ -29,5 +29,5 @@ func New(cfg *kafka.Config, c kafka.ConsumeFn) kafka.Cronsumer { | |||
| cfg.Logger.Infof("Topic [%s] verified successfully!", cfg.Consumer.Topic) | |||
| } | |||
|
|
|||
| return internal.NewCronsumer(cfg, c) | |||
| return internal.NewCronsumerClient(cfg, c) | |||
There was a problem hiding this comment.
I think, no need to put Client as suffix
internal/cron_client.go
Outdated
| gocron "github.com/robfig/cron/v3" | ||
| ) | ||
|
|
||
| type cronsumerClient struct { |
There was a problem hiding this comment.
I think, this file is not cron_client, it initializes cronsumer etc.
| @@ -447,6 +447,48 @@ func Test_Should_Discard_Message_When_Header_Filter_Defined(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func Test_Should_Consume_Exception_Message_Successfully_When_Duration_Zero(t *testing.T) { | |||
There was a problem hiding this comment.
we need to refactor this
|
Linter check 🙏🏻 |
internal/cron_client.go
Outdated
| }) | ||
| } | ||
|
|
||
| func (s *cronsumerClient) startListen(cfg kafka.ConsumerConfig) func() { |
There was a problem hiding this comment.
pay attention to goroutine leak, refactor here
Abdulsametileri
requested changes
Aug 8, 2024
Abdulsametileri
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By disabling the duration feature, the exception topic is continuously consumed. When the messages that come after the cron statement is triggered are consumed while they are in the currently running batch process, the current consumption process is closed and this message is published to the topic again to be consumed at the new trigger time.
This PR also includes naming changes.
#77