Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable/disable cron #78

Closed
wants to merge 4 commits into from
Closed

Conversation

ugurcanerdogan
Copy link
Member

#77

@ugurcanerdogan ugurcanerdogan added the enhancement New feature or request label Jul 5, 2024
@ugurcanerdogan ugurcanerdogan self-assigned this Jul 5, 2024
@ugurcanerdogan ugurcanerdogan linked an issue Jul 5, 2024 that may be closed by this pull request
@Abdulsametileri
Copy link
Member

We need to also think startConsume method logic

for {
		m, err := k.kafkaConsumer.ReadMessage(ctx)
		if err != nil {
			k.cfg.Logger.Warnf("Message from %s could not read, error %s", k.cfg.Consumer.Topic, err.Error())
			return
		}
		if m == nil {
			return
		}

		msg := NewMessageWrapper(*m, strategyName)

		if k.skipMessageByHeaderFn != nil && k.skipMessageByHeaderFn(msg.Headers) {
			k.cfg.Logger.Infof("Message from %s is not processed. Header filter applied. Headers: %v", k.cfg.Consumer.Topic, msg.Headers)
			continue
		}

		if msg.ProduceTime >= startTimeUnixNano {
			(*cancelFuncWrapper)()

			k.cfg.Logger.Info("Next iteration message has been detected, resending the message to exception")

			if err = k.kafkaProducer.ProduceWithRetryOption(*msg, false, false); err != nil {
				k.cfg.Logger.Errorf("Error %s sending next iteration KafkaMessage: %#v", err.Error(), *msg)
			}

			return
		}

		if retryStrategy.String() == kafka.FixedBackOffStrategy {
			k.sendToMessageChannel(*msg)
			continue
		}

If you look carefully, there are some checks like produceTime etc.

@Abdulsametileri
Copy link
Member

Also, I want to ask you, Did you test this implementation in the dev environment?

@ugurcanerdogan ugurcanerdogan deleted the feature/enable&disable-cron branch August 8, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: enable/disable duration
2 participants