Add a new permission flag to toggle snowfall, like you would for firespread #7690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some things i know need to be looked at:
|
LlmDl
requested changes
Dec 2, 2024
There was a problem hiding this comment.
You can undo the changes to this class, there's no more room available in the perm hud scoreboard, its already at 15 lines.
| @@ -2240,6 +2253,7 @@ public enum ConfigNodes { | |||
| "default_perm_flags.town.default.explosion", | |||
| "false"), | |||
| FLAGS_TOWN_DEF_MOBS("default_perm_flags.town.default.mobs", "false"), | |||
| FLAGS_TOWN_DEF_SNOW("default_perm_flags.town.default.snow", "true"), // TODO: fruit add node to config | |||
There was a problem hiding this comment.
This class needs more help lines, the ones I've spotted are
TA_TOWN_TOGGLE,
TOWN_TOGGLE_HELP,
PLOT_GROUP_TOGGLE,
PLOT_TOGGLE
| case "snow": | ||
| checkPermOrThrow(player, PermissionNodes.TOWNY_COMMAND_PLOT_TOGGLE_SNOW.getNode()); | ||
| tryToggleTownBlockSnow(player, townBlock, split, choice); | ||
| TownyMessaging.sendMsg(player, Translatable.of("msg_changed_snow", "the Plot", townBlock.getPermissions().snow ? Translatable.of("enabled") : Translatable.of("disabled"))); |
There was a problem hiding this comment.
This does need a break; added to the end of it, I think you'd mentioned this.
| @@ -2039,6 +2064,9 @@ public void plotGroupToggle(Player player, Resident resident, PlotGroup plotGrou | |||
| tryToggleTownBlockMobs(player, groupBlock, split, choice); | |||
| endingMessage = Translatable.of("msg_changed_mobs", Translatable.of("msg_the_plot_group"), groupBlock.getPermissions().mobs ? Translatable.of("enabled") : Translatable.of("disabled")); | |||
| break; | |||
| case "snow": | |||
| tryToggleTownBlockSnow(player, groupBlock, split, choice); | |||
| endingMessage = Translatable.of("msg_changed_snow", Translatable.of("msg_the_plot_group"), groupBlock.getPermissions().snow ? Translatable.of("enabled") : Translatable.of("disabled")); | |||
| // Set the toggle setting. | ||
| town.setSnow(preEvent.getFutureState()); | ||
|
|
||
| // TODO: add these messages |
There was a problem hiding this comment.
Adding anything to the SQLSource also requires an addition to the SQLSchema class, so the columns will be created.
| @@ -617,6 +619,7 @@ msg_changed_public: '&cThe Town''s public status is now %s.' | |||
| msg_changed_expl: '&cExplosions in %s are now %s.' | |||
| msg_changed_fire: '&cFirespread in %s is now %s.' | |||
| msg_changed_mobs: '&cMonster spawns in %s are now %s.' | |||
| msg_changed_snow: '&cSnowfall in %s is now %s' | |||
There was a problem hiding this comment.
Missing a period on the end of this string.
Comment on lines
2178
to
2179
| msg_perm_hud_snowfall: 'Snowfall: ' | ||
| #Seen in /plot perm hud: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I made this pull request as in my experience many people dread making towns in snow due to the constant covering of your builds in snow. It takes a lot of time and maintenance to keep your town clean, I've seen some go to the extreme of placing thousands of iron bars at the highest Y level to prevent snowfall. I think it is fair to add the ability to toggle this for players, if lag is a concern server admins can force snowfall on or otherwise remove access to turning it off.
New Nodes/Commands/ConfigOptions:
New config nodes:
new_world_settings.snow.world_snowfall_enablednew_world_settings.snow.force_snow_onNew commands and their permissions:
/town toggle snowtowny.command.town.toggle.snow/plot toggle snowtowny.command.plot.toggle.snow/res toggle snowtowny.command.resident.toggle.snow/tw toggle snowtowny.command.townyworld.toggle.snow/tw toggle forcesnowtowny.command.townyworld.toggle.forcesnowRelevant Towny Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.