Allow users to define their own item/entity lists #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
force-pushed
the
feat/configurable-registry-lists
branch
from
85da3e2 to
466dcf7
Compare
Warriorrrr
force-pushed
the
feat/configurable-registry-lists
branch
from
7546db6 to
e3f16c6
Compare
Warriorrrr
force-pushed
the
feat/configurable-registry-lists
branch
from
e3f16c6 to
3de76da
Compare
|
Running the version compiled from newest commit appears to have changed my townblocktypes section to this |
LlmDl
requested changes
Feb 26, 2024
Comment on lines
+3157
to
+3284
| "# This section of the config allows you to specify custom lists of blocks or entities, that can then be used elsewhere in the config.", | ||
| "# A custom syntax is used to specify whether to include or exclude certain patterns from the resulting set.", | ||
| "#", | ||
| "# Format:", | ||
| "# *string: Includes all elements that end with 'string'", | ||
| "# string*: Includes all elements that start with 'string'", | ||
| "# !*string: Excludes all elements that don't end with 'string'", | ||
| "# !string*: Excludes all elements that don't start with 'string'", | ||
| "# #tag: Includes all elements that are contained in the given tag, valid tags can be found here: https://github.com/misode/mcmeta/tree/data/data/minecraft/tags in the blocks or entity_type folders.", | ||
| "# !#tag: Excludes all elements that are contained in the given tag", | ||
| "# +string: Includes the element with name 'string'", | ||
| "# -string: Excludes the element with name 'string'", | ||
| "# ~string: Includes all elements that contain 'string' in the name", | ||
| "# !~string: Excludes all elements that contain 'string' in the name", | ||
| "# c:class: Includes all elements that are instances of the given class"), |
There was a problem hiding this comment.
This ought to be boxed in with a header like the other config sections, if the header is a bit wider than they are normally that's fine.
| @@ -705,10 +712,10 @@ private static void setDefaults(String version, Path configPath) { | |||
| } else if (root.getRoot().equals(ConfigNodes.LAST_RUN_VERSION.getRoot())) { | |||
| setNewProperty(root.getRoot(), getLastRunVersion(version)); | |||
| } else if (root.getRoot().equals(ConfigNodes.TOWNBLOCKTYPES_TYPES.getRoot())) { | |||
| setNewProperty(root.getRoot(), root.getDefault()); | |||
| setNewProperty(root.getRoot(), root.defaultValue()); | |||
There was a problem hiding this comment.
In my experience handling maps gets a bit weird, this is likely the point where townblocktypes stopped working. I ran into something similar in TownyChat when changing the channels.yml over to commented config.
There was a problem hiding this comment.
That's because setNewProperty used to always toString the value, but this is removed here
Warriorrrr
force-pushed
the
feat/configurable-registry-lists
branch
from
e74d5ed to
d074fa8
Compare
Warriorrrr
force-pushed
the
feat/configurable-registry-lists
branch
from
d074fa8 to
ddb8366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.