Towny with less than 100 NotRegisteredException mentions. #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing over basecommand to use townyexception instead of not registered. Deprecate a few TownyWorlds methods. Replace a ton more NRE-throwing calls with safe tests. Remove more NRE generating code, (probably temporarily) deprecate some methods that throw NREs. Tactically nuked the NREs from orbit. Not longer thrown internally by any of the Towny Objects. Some of which are deprecated, some not. Next step might be dealing with loading of spawn locations after checking how the UUID db branch dealt with it. (If it did.) Following that, start merging things from this into smaller PRs made to Towny, starting with the safest options. Basic grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not intended to be merged
This branch is the result of systematically tracking down and replacing many of the ways Towny can throw a NotRegisteredException.
This includes:
Todo:
The resulting branch will then be used to merge smaller, safe changes until there's some hard decisions to be made about the usage of NREs. I envision them only being thrown by TownyUniverse and only used to denote in-memory discrepancies.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.