Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non-http errors correctly (#375) #376

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

silentjohnny
Copy link
Contributor

Added a check for result property present in error, otherwise call back with error instance.

@eladnava eladnava merged commit 07ee1af into ToothlessGear:master Oct 7, 2023
5 checks passed
@eladnava eladnava mentioned this pull request Oct 7, 2023
@eladnava
Copy link
Collaborator

eladnava commented Oct 7, 2023

Thanks for catching this and submitting a PR @silentjohnny!

Merged and published to npm as 1.1.1. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants