-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace request with axios #372
Conversation
@eladnava are you able to review PRs? Asking since you have the last merged PR. |
Hi @pmb-cl, Unfortunately, it is not enough to replace the After cloning your PR branch That's because Axios expects a Sending a POST request using Axios can be done using the following promise-based syntax:
|
@eladnava Thanks for the review man! I got it to work now, but need to fix the tests. I'll try and knock that out this weekend when I'm working on some other stuff. |
@eladnava Should be good to go now. Please review and let me know your thoughts. |
@eladnava pls re-review when you get a chance. Thanks for all the rounds of feedback so far! |
Hi @pmb-cl, Can you please re-generate the lock file using Node v12 (or replace it with the following contents?)
|
@eladnava rebuilt |
Merged & published to Thanks so much for your help with this @pmb-cl! |
Request is deprecated, replacing with a newer library.
Tested and working.