BfA fix #7
Open
BfA fix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toludin
reviewed
Jul 17, 2018
There was a problem hiding this comment.
Honestly I think you should probably host this as your own update - mine were very small, just a few quick fixes for a friend for the sound file mid-Legion change. I don't use MSBT myself so I think it would make more sense for you to make your own fork, as it's clear you understand this addon better than I do and are more likely to keep it updated moving forward. Nice job!
MSBT would error out at MSBTProfiles.lua lines 1041 and 1047 with string concatenation errors when trying to load. Re-Adding L.MSG_AC and L.MSG_AC_FULL fixes the issue
Add missing expected L.MSG_AC and L.MSG_AC_FULL
|
Thanks for your suggestion. I'd maintain this one as possible as I can. But this project should be temporary because the author still maintain his own addons and it will be fixed soon by him. I'd do my best if you give permission to me even though I'm very noob in github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed MSBT for BfA 8.0