Minor version bump and remove undocumented stuff

* Removing the `modality` property as it was completely undocumented or tested
Tokazama · Feb 8, 2020 · df0ef60 · df0ef60 · Tokazama · Feb 8, 2020
1 parent 7fb4095
commit df0ef60
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 14 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "FieldProperties"
 uuid = "127e4479-4c95-493a-afaa-609d38175b70"
 authors = ["zchristensen "]
-version = "0.5.1"
+version = "0.5.2"
 
 [deps]
 Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a"

diff --git a/src/FieldProperties.jl b/src/FieldProperties.jl
@@ -21,15 +21,13 @@ export
     @defprop,
     @properties,
     propconvert,
-    proptype,
+    proptype,  # TODO remove after deprecation
     # general properties
     description,
     description!,
     description_list,
     status,
     status!,
-    modality,
-    modality!,
     name,
     name!,
     label,

diff --git a/src/general.jl b/src/general.jl
@@ -1,8 +1,6 @@
 # general properties that just need a home
 @defprop Status{:status}
 
-@defprop Modality{:modality}
-
 """
 Property providing label for parent structure.
 """

diff --git a/src/properties.jl b/src/properties.jl
@@ -1,5 +1,4 @@
 """
-
     @properties T block
 
 Syntactic sugar for custom `getproperty`, `setproperty!`, and `propertynames` methods.
@@ -209,13 +208,6 @@ macro properties(T, lines)
                             nested_getter_blk = callexpr(esc(:getproperty), callexpr(esc(:getfield), esc(self), body), esc(:p))
                         end
                         !in(body, nested_names) && push!(nested_names, body)
-                    elseif body isa Symbol
-                        if is_setter
-                            nested_setter_blk = callexpr(esc(:setproperty!), callexpr(esc(:getfield), esc(self), QuoteNode(body)), esc(:p), esc(val))
-                        else
-                            nested_getter_blk = callexpr(esc(:getproperty), callexpr(esc(:getfield), esc(self), QuoteNode(body)), esc(:p))
-                        end
-                        !in(body, nested_names) && push!(nested_names, body)
                     elseif body isa Expr && body.head == :tuple
                         body = body.args
                         n = length(body)