Ensure fallback implementation is always, for-real, available.

TkTech · Feb 4, 2024 · 2c49da2 · 2c49da2
1 parent 545bc1c
commit 2c49da2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/setup.py b/setup.py
@@ -29,19 +29,21 @@
         ' available.'
     )
 
+macros = [
+    ('SIMDJSON_IMPLEMENTATION_FALLBACK', "1"),
+]
 if os.getenv('BUILD_WITH_CYTHON') and CYTHON_AVAILABLE:
-    macros = []
     compiler_directives = {
         'embedsignature': True
     }
 
     if os.getenv('BUILD_FOR_DEBUG'):
         # Enable line tracing, which also enables support for coverage
         # reporting.
-        macros = [
-            ('CYTHON_TRACE', 1),
-            ('CYTHON_TRACE_NOGIL', 1)
-        ]
+        macros.extend([
+            ('CYTHON_TRACE', "1"),
+            ('CYTHON_TRACE_NOGIL', "1")
+        ])
         compiler_directives['linetrace'] = True
 
     force = bool(os.getenv('FORCE_REBUILD'))
@@ -67,6 +69,7 @@
                 'simdjson/util.cpp',
                 'simdjson/csimdjson.cpp'
             ],
+            define_macros=macros,
             extra_compile_args=extra_compile_args,
             language='c++'
         )

diff --git a/simdjson/csimdjson.cpp b/simdjson/csimdjson.cpp