src fixes

TerriaJS · Sep 17, 2024 · d0ca149 · d0ca149
1 parent c12a132
commit d0ca149
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -87,7 +87,7 @@
     /* Variables */
     "no-label-var": 1,
     "no-unused-vars": [
-      1,
+      "warn",
       {
         "vars": "local",
         "args": "none"
@@ -111,10 +111,11 @@
   },
   "overrides": [
     {
-      "files": ["**/*.ts", "**/*.tsx"],
+      "files": ["*.ts", "**/*.tsx"],
       "rules": {
         // @TODO: revise these rules
         "@typescript-eslint/consistent-type-assertions": "error",
+        "no-unused-vars": "off",
         "@typescript-eslint/no-unused-vars": [
           "warn",
           {
@@ -125,7 +126,7 @@
         ],
         "@typescript-eslint/ban-ts-comment": "warn",
         "@typescript-eslint/no-loss-of-precision": "warn",
-        "@typescript-eslint/no-unsafe-declaration-merging": "warn",
+        "@typescript-eslint/no-unsafe-declaration-merging": "off",
         "react-hooks/exhaustive-deps": "warn",
         "react/prop-types": "warn"
       }

diff --git a/lib/Models/Catalog/Ckan/CkanItemReference.ts b/lib/Models/Catalog/Ckan/CkanItemReference.ts
@@ -50,7 +50,7 @@ export class CkanDatasetStratum extends LoadableStratum(
     makeObservable(this);
   }
 
-  duplicateLoadableStratum(newModel: BaseModel): this {
+  duplicateLoadableStratum(_newModel: BaseModel): this {
     return new CkanDatasetStratum(
       this.ckanItemReference,
       this.ckanCatalogGroup

diff --git a/lib/Table/TableColumn.ts b/lib/Table/TableColumn.ts
@@ -920,6 +920,6 @@ function toNumber(value: string): number | null {
   return null;
 }
 
-function nullFunction(rowIndex: number) {
+function nullFunction() {
   return null;
 }
diff --git a/lib/Traits/Decorators/modelReferenceArrayTrait.ts b/lib/Traits/Decorators/modelReferenceArrayTrait.ts
@@ -13,7 +13,7 @@ export interface ModelArrayTraitOptions extends TraitOptions {
   factory?: ModelFactory;
 }
 
-export default function modelReferenceArrayTrait<T>(
+export default function modelReferenceArrayTrait<_T>(
   options: ModelArrayTraitOptions
 ) {
   return function (target: any, propertyKey: string) {

diff --git a/lib/Traits/Decorators/modelReferenceTrait.ts b/lib/Traits/Decorators/modelReferenceTrait.ts
@@ -12,7 +12,7 @@ export interface ModelTraitOptions extends TraitOptions {
   factory?: ModelFactory;
 }
 
-export default function modelReferenceTrait<T>(options: ModelTraitOptions) {
+export default function modelReferenceTrait<_T>(options: ModelTraitOptions) {
   return function (target: any, propertyKey: string) {
     const constructor = target.constructor;
     if (!constructor.traits) {

diff --git a/lib/Traits/Decorators/primitiveArrayTrait.ts b/lib/Traits/Decorators/primitiveArrayTrait.ts
@@ -5,7 +5,7 @@ import Trait, { TraitOptions } from "../Trait";
 
 type PrimitiveType = "string" | "number" | "boolean";
 
-export interface PrimitiveArrayTraitOptions<T> extends TraitOptions {
+export interface PrimitiveArrayTraitOptions<_T> extends TraitOptions {
   type: PrimitiveType;
   isNullable?: boolean;
 }

diff --git a/lib/Traits/Decorators/primitiveTrait.ts b/lib/Traits/Decorators/primitiveTrait.ts
@@ -5,7 +5,7 @@ import Trait, { TraitOptions } from "../Trait";
 
 type PrimitiveType = "string" | "number" | "boolean";
 
-export interface PrimitiveTraitOptions<T> extends TraitOptions {
+export interface PrimitiveTraitOptions<_T> extends TraitOptions {
   type: PrimitiveType;
   isNullable?: boolean;
 }