Finalize bot model, rename Difficulty->Bot #441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
Since the choice of bot depends on both timing and difficulty considerations, we renamed the
Difficulty
enum toBot
across the codebase.At present only
KataGoInstant
andKataGoFullStrength
are available as choices.This naming can support the addition of
GnuGo::Easy
andGnuGo::Medium
difficulties in #440, as well.Additionally, we were able to remove a read call to Redis within
botlink
service by combining the concept of "is a bot attached to this game_id and player?" with the specific type of bot that was requested. This is locally named anAttachment
-- and is not important to any other component in the system.This ticket advances #322.
Work effort
Use rev
29163ac
in Cargo.toml deps.Cargo.toml
deps)Bot
enum