Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize bot model, rename Difficulty->Bot #441

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Conversation

Terkwood
Copy link
Owner

@Terkwood Terkwood commented Oct 30, 2020

Justification

Since the choice of bot depends on both timing and difficulty considerations, we renamed the Difficulty enum to Bot across the codebase.

At present only KataGoInstant and KataGoFullStrength are available as choices.

This naming can support the addition of GnuGo::Easy and GnuGo::Medium difficulties in #440, as well.

Additionally, we were able to remove a read call to Redis within botlink service by combining the concept of "is a bot attached to this game_id and player?" with the specific type of bot that was requested. This is locally named an Attachment -- and is not important to any other component in the system.

This ticket advances #322.

Work effort

Use rev 29163ac in Cargo.toml deps.

  • DO NOT SQUASH the pull request (we're using a rev# in this PR for Cargo.toml deps)
  • rebase commits
  • rename and restructure Bot enum
  • update botlink
  • combine botlink repos
  • update gateway
  • update browser
  • update tinybrain
  • local test

@Terkwood Terkwood added the tech-debt Lib upgrades, Carryover from prior decisions, &c label Oct 30, 2020
@Terkwood Terkwood changed the title Finalize bot model, rename Difficulty->BotMode Finalize bot model, rename Difficulty->Bot Oct 30, 2020
@Terkwood Terkwood marked this pull request as ready for review October 30, 2020 20:19
@Terkwood Terkwood force-pushed the fix/bot-model branch 3 times, most recently from e5a0fa3 to c68a956 Compare October 30, 2020 20:28
@Terkwood Terkwood merged commit fb7b7ba into unstable Oct 30, 2020
@Terkwood Terkwood deleted the fix/bot-model branch October 30, 2020 20:38
@Terkwood Terkwood mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant