Add features needed by patch library
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endgame
commented
Apr 23, 2020
Use `mappend` to support versions of base that doen't have Semigroup.
Taneb
reviewed
Apr 24, 2020
|
Is there anything else that needs to happen here? |
|
Just checking in again - is there anything else you need from me for this? |
Taneb
reviewed
May 11, 2020
|
@Taneb Anything else you need from me here? |
|
@Taneb Anything else necessary to get this merged? |
|
Having thought it over for a while, I'm not happy with the splitting of the copyright for this library. Either can you transfer me the copyright, or I can ask someone who hasn't seen this PR to implement those particular instances from scratch. |
|
It's not my copyright to transfer. I can ping someone from Obsidian but I think it would be faster to ask someone to cleanroom it. |
Ryan Trinkle (Partner, Obsidian Systems) consented to this: Taneb#3 (comment)
|
Okay @Taneb, how's this? |
|
Thanks heaps! |
|
I'll get this released ASAP |
|
And released! https://hackage.haskell.org/package/groups-0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: reflex-frp/patch#4
This PR:
Adds
(~~)as a group subtraction operator, as it was inpatch'sGroupclass. It isinfixl 7based on the discussion inUse Group from elsewhere reflex-frp/patch#4 .
Adds instances for every type present in
base. Instances forMonoidalMapare not ported across, becausemonoidal-containerspulls in
lens. If this PR is accepted, I will PRmonoidal-containersto move those instances.Adds a few obvious
Cyclicinstances.Note: To write instances for
(:*:)and(:.:), I had to turn on-XTypeOperators. This means that we're no longer pure Haskell98. Thecabal documentation has been updated to reflect this. I wrote out the
instances for
ConstandIdentityby hand to avoid turning on-XStandaloneDerivingand-XGeneralizedNewtypeDeriving.