Skip to content

Commit

Permalink
[TASK] Improve phpdoc formatting (#988)
Browse files Browse the repository at this point in the history
This helps some IDEs with parsing phpdocs correctly.
  • Loading branch information
s2b authored Aug 24, 2024
1 parent eb62c34 commit 5853226
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function preProcessSource(string $templateSource): string
* of the template string for the exception handler to reference to.
*
* @todo It should be evaluated if this is really necessary. If it is, it should
* be moved to a separate TemplateProcessor (which would be a breaking change)
* be moved to a separate TemplateProcessor (which would be a breaking change)
*/
public function replaceCdataSectionsByEmptyLines(string $templateSource): string
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
* argument is specified and not empty.
*
* @deprecated Will be removed in v5. No longer necessary since getContentArgumentName() has been
* integrated into AbstractViewHelper with v2.15. Name has to be specified explicitly by overriding the
* method, implicit definition (= first optional argument) is no longer supported.
* integrated into AbstractViewHelper with v2.15. Name has to be specified explicitly
* by overriding the method, implicit definition (= first optional argument) is no
* longer supported.
*/
trait CompileWithContentArgumentAndRenderStatic
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Functional/ViewHelpers/IfThenElseViewHelperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -490,9 +490,9 @@ public static function renderDataProvider(): \Generator
['verdict' => false],
0,
];
/**
/*
* @todo This should work but doesn't at the moment. This is probably related to the boolean
* parser not converting variable nodes correctly. There is a related todo in the BooleanParserTest.
* parser not converting variable nodes correctly. There is a related todo in the BooleanParserTest.
yield 'test' => [
'<f:if condition="{test}"><f:then>then</f:then><f:else>else</f:else></f:if>',
['test' => '""'],
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Core/Parser/BooleanParserTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public static function getSomeEvaluationTestValues(): array

/*
* @todo This should work but doesn't at the moment. This is probably related to the boolean
* parser not converting variable nodes correctly. There is a related todo in the IfThenElseViewHelperTest.
* parser not converting variable nodes correctly. There is a related todo in the IfThenElseViewHelperTest.
['{foo}', true, ['foo' => '""']],
*/
];
Expand Down

0 comments on commit 5853226

Please sign in to comment.