Add note to check liquibase command run correctly #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricongjh
approved these changes
Apr 21, 2024
NicolasCwy
suggested changes
Apr 21, 2024
| @@ -104,7 +104,8 @@ New releases are made every set period of time (typically every week), in which | |||
| * Before release day: | |||
| * [Create an issue for the release](https://github.com/TEAMMATES/teammates/issues/new?template=release.md) to announce the scheduled release time. | |||
| * Update the "about page" with the names of new contributors, if any. | |||
| * Check if any schema change is needed for this release. If so, inform PM that this release requires maintainance mode and generate Liquibase changelog (refer to [Schema Migration](#schema-migration)). | |||
| * Check if any schema change is needed for this release. If so, generate Liquibase changelog (refer to [Schema Migration](#schema-migration)) and inform PM that this release requires maintainance mode. | |||
There was a problem hiding this comment.
Is maintenance mode needed? I thought that prod should never go down for schema changes, we could correct this here
There was a problem hiding this comment.
Hopefully, most schema changes are backward compatible (i.e., no need to go into maintenance mode) but some might not be. So, should cover both cases in the docs.
There was a problem hiding this comment.
@damithc schema changes + data migration in SQL is no different than that in Datastore. There is no need for any additional concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline of Solution