Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple JsonShell #673

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Add simple JsonShell #673

merged 2 commits into from
Jan 5, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Oct 6, 2023

Adapted the python shell to make a simple json reporter.

Analyzing how this implementation behaves shows a few issues:

  • The reported json object represents only the actions, not the current state of the module. So then what should the json interface report:
    • Specific actions of set/unset/shell_function etc. as specific keys to the json object? Then the consumer would have to keep track of the state of the environment variables setting/unsetting/updating
    • Expand the base table in the lua script and just output the final state
  • Commands like module list do not produce a meaningful tbl to be exported as json

rtmclay pushed a commit that referenced this pull request Nov 6, 2023
rtmclay pushed a commit that referenced this pull request Nov 6, 2023
rtmclay pushed a commit that referenced this pull request Nov 6, 2023
rtmclay pushed a commit that referenced this pull request Nov 6, 2023
@rtmclay
Copy link
Member

rtmclay commented Dec 4, 2023

This pull request has been merged on to the testing branch. Please try the Lmod testing branch to see if it works for you.

@rtmclay rtmclay merged commit 18e7561 into TACC:main Jan 5, 2024
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants