-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful client close (fix #36) #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kylmakalle
force-pushed
the
gracefull-close
branch
from
July 7, 2023 14:42
5737391
to
e0342d9
Compare
TDLibKit/scripts/tl2swift/Sources/TlParserLib/Composer/MethodsComposer.swift Lines 192 to 239 in a4d1640
Please, also pay attention here, I think remove And I fix it in my PR #37. |
Co-Authored-By: XMLHexagram <[email protected]>
@XMLHexagram addressed, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes #36 and makes the client close properly. However, trying to call
client.run()
immediately after theclient.close()
may result in non-working client. I assume this scenario is quite rare.This PR does not interfere with public API much, except for some
throws
, but I believe nobody care about these two404s "Client destroyed"