[Rebase] Warn users on possible risks on installing third party unvetted plugins #676
Conversation
| // save intervalId to clear the interval when the | ||
| // component re-renders | ||
| const intervalId = setInterval(() => { | ||
| setWaitTimer(waitTimer - 1); |
There was a problem hiding this comment.
Wouldn't set timeout work better for this then? Unless I'm misunderstanding?
There was a problem hiding this comment.
Yeah, fair enough. Not really that skilled with react.
There was a problem hiding this comment.
@AAGaming00 current solution isn't ideal but should it be changed or can this PR go ahead?
There was a problem hiding this comment.
Rereading this now, no, because I'm referencing the timeout on the translation on line 58 to show the remaining time ticking down to give additional feedback to the user, so I can't see how I would be doing this with one single timeout tick compared to one for each second. It was like 6 months from when I wrote this, so I was not that sure why I did stuff at the time, sorry XD. Let me know if I'm missing something.
RodoMa92
changed the title
Please tick as appropriate:
Description
This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.