-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make asset extraction a local action #366
base: master
Are you sure you want to change the base?
Conversation
If you want to save space without setting the |
I think this is more a forward looking solution. Re-writing got history is a pain with minimal benefits rn imo |
Also, it is no longer just the assets folder. There are extracted JSON object files under The |
Is there a reason to use os dependent scripts rather than running a rust program? |
I suppose not... but I think it's a bit overkill for what boils down to running commands in a sequence |
Description
With changes with minecraft versions, asset files can have massive changes causing a lot of bloat on the git repo that can lead to MBs of extra un-needed data.
This PR introduces a script to generate and move asset files from the extractor to their locations in the project root as well as a workflow artifact for users to download rather than extract if they prefer
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy
cargo test