Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented /msg, /tell and /w commands #254

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KaliemSB
Copy link

@KaliemSB KaliemSB commented Nov 11, 2024

Description

  • Added /msg command.
  • Added /tell command.
  • Added /w command.

All commands were implemented according to the wiki.

Testing

  • Msg command on self, player, players.
  • This pull request has been tested and compared against both Vanilla and Paper versions.

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy

Copy link
Contributor

@user622628252416 user622628252416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good IMO, I just noticed some minor things

pumpkin/src/command/commands/cmd_msg.rs Outdated Show resolved Hide resolved
pumpkin/src/command/commands/cmd_msg.rs Outdated Show resolved Hide resolved
@Snowiiii
Copy link
Owner

You should use Chat Types. They also include a message (e.g. .... whispers to ...).
There are Chat Types parsed from the registry. I think it would be cool to automaticlly/manuelly make an Enum for Chat Types

@KaliemSB
Copy link
Author

You should use Chat Types. They also include a message (e.g. .... whispers to ...). There are Chat Types parsed from the registry. I think it would be cool to automaticlly/manuelly make an Enum for Chat Types

I researched and read about these Chat Types, and it seems to be the correct way to send these messages. However, I have no idea how to use or implement it ☠️☠️☠️

@Commandcracker Commandcracker mentioned this pull request Nov 18, 2024
2 tasks
@KaliemSB
Copy link
Author

Waiting this PR to be merged #324

@Commandcracker Commandcracker mentioned this pull request Nov 23, 2024
2 tasks
@lucas11222
Copy link
Contributor

fix conflicts and make for the chat types

@Snowiiii
Copy link
Owner

Waiting this PR to be merged #324

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants