-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented /msg, /tell and /w commands #254
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good IMO, I just noticed some minor things
You should use Chat Types. They also include a message (e.g. .... whispers to ...). |
I researched and read about these Chat Types, and it seems to be the correct way to send these messages. However, I have no idea how to use or implement it ☠️☠️☠️ |
Waiting this PR to be merged #324 |
fix conflicts and make for the chat types |
Merged |
Description
/msg
command./tell
command./w
command.All commands were implemented according to the wiki.
Testing
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy