Sanitize null bytes in eval'ed text #1538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both vim and neovim error out if we try to evaluate a string with a null byte in it. It appears that they use
<NL>
to represent<Nul>
in several places, so replace any null bytes in text passed tovim_helper.eval()
with newlines.In my testing, I copied text from a file containing a null byte and pasted it into the commands that were giving errors, and found that the null byte does get treated as a word boundary in that case:
ultisnips/pythonx/UltiSnips/snippet/definition/base.py
Lines 345 to 347 in 24a3ebb
ultisnips/pythonx/UltiSnips/snippet/definition/base.py
Lines 388 to 392 in 24a3ebb
Fixes #1386.