Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change license to GPLv3 #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change license to GPLv3 #129

wants to merge 2 commits into from

Conversation

udenr
Copy link
Contributor

@udenr udenr commented Sep 9, 2024

This PR fixes the issue with inconsistent licenses as decribed in #116

@udenr udenr mentioned this pull request Sep 9, 2024
Open
0xC0FFEEC0DE
0xC0FFEEC0DE requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@0xC0FFEEC0DE 0xC0FFEEC0DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to the existing changes. But the following files also show Apache as license of the app:

  • \app\src\main\res\values\strings.xml
  • \app\src\main\res\values-nl\strings.xml

They should be changed too. See string with name "privacy_friendly".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kamuno Kamuno Kamuno approved these changes

@nico1509 nico1509 nico1509 approved these changes

@coderPaddyS coderPaddyS coderPaddyS approved these changes

@0xC0FFEEC0DE 0xC0FFEEC0DE 0xC0FFEEC0DE approved these changes

@petermayer petermayer Awaiting requested review from petermayer

@Yonjuni Yonjuni Awaiting requested review from Yonjuni

@sbreitf1 sbreitf1 Awaiting requested review from sbreitf1

@sleep-yearning sleep-yearning Awaiting requested review from sleep-yearning

@Naitbobbes Naitbobbes Awaiting requested review from Naitbobbes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@udenr @Kamuno @nico1509 @coderPaddyS @0xC0FFEEC0DE