Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add air actions #39

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Add air actions #39

merged 5 commits into from
Sep 6, 2024

Conversation

RobbieNesmith
Copy link
Contributor

Add air actions for using Samsung's S Pen.

Tested on Samsung Galaxy S24 Ultra. It should work on Note 10 and 20, S22 Ultra and up, and Tab S6 and up.

I do not speak any German, so my translations in the strings.xml files might be bad.

@udenr udenr changed the base branch from master to development September 3, 2024 13:16
@udenr
Copy link
Contributor

udenr commented Sep 3, 2024

Thank you for your contribution.
I just updated everything to the current state of the development branch.
As far as I can see you forgot to add the xml/air_actions to the git.
Also I don't have a device to test, so it would be great if you could test the current version again.

@RobbieNesmith
Copy link
Contributor Author

Ah yes, I did miss that file thanks for catching that. I'll get that added in. Also (this is just a personal preference of how I use git) I prefer not to have merge commits back into a feature branch so I've rebased my changes on top of the current development branch.

I tested again after doing this rebase and my air actions do work.

@RobbieNesmith
Copy link
Contributor Author

Oh I also removed my commit to update the compileSdk since it has already been done.

@udenr udenr merged commit 7d6d38e into SecUSo:development Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants