Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning_FlowScreen support #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JeroenSfdc
Copy link

@JeroenSfdc JeroenSfdc commented Jun 7, 2021

This will support Lightning_FlowScreen as target. See issue #66

Description

  • Added the necessary Lightning_FlowScreen target
  • Removed datasource attributes as these are not supported today by Flow.

Motivation and Context

#66
Flow is a very relevant target to show Charts.

How Has This Been Tested?

Ceated a demo Flow.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This can break for package upgrades, as there is a bug with updating an pre-existing targets, when a Lightning_FlowScreen is being added. GUS Work Item: W-9032710

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@JeroenSfdc
Copy link
Author

@victorgz any chance you feel this PR could be a reasonable enhancement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant