Tidy up the code

Sage · Jun 21, 2024 · 7ad3551 · 7ad3551
1 parent 1a84c48
commit 7ad3551
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 41 deletions.
diff --git a/lib/zuora/attributes.rb b/lib/zuora/attributes.rb
@@ -210,8 +210,6 @@ def attributes
     def clear_changed_attributes!
       clear_changes_information
       self
-      # @changed_attributes = {}
-      # self
     end
 
     # the name to use when referencing remote Zuora objects

diff --git a/lib/zuora/objects/amendment.rb b/lib/zuora/objects/amendment.rb
@@ -42,7 +42,6 @@ def apply_response(response_hash, type)
         self.invoice_id = result[:invoice_id]
         self.payment_transaction_number = result[:payment_transaction_number]
         @previously_changed = changes
-        # @changed_attributes.clear
         clear_changes_information
         return true
       else

diff --git a/lib/zuora/objects/base.rb b/lib/zuora/objects/base.rb
@@ -44,7 +44,6 @@ def reload!
         self.send("#{k}=", v)
       }
       @previously_changed = changes
-      # @changed_attributes = ActiveSupport::HashWithIndifferentAccess.new
       clear_changes_information
       self
     end
@@ -192,8 +191,6 @@ def apply_response(response_hash, type)
       if result[:success]
         self.id = result[:id]
         @previously_changed = changes
-        # require 'pry'; binding.pry
-        # @changed_attributes = ActiveSupport::HashWithIndifferentAccess.new
         clear_changes_information
         return true
       else

diff --git a/lib/zuora/objects/subscribe_request.rb b/lib/zuora/objects/subscribe_request.rb
@@ -55,7 +55,6 @@ def apply_response(response_hash, type)
         subscription.name = result[:subscription_number]
         subscription.clear_changed_attributes!
         @previously_changed = changes
-        # @changed_attributes = ActiveSupport::HashWithIndifferentAccess.new
         clear_changes_information
       else
         self.errors.add(:base, result[:errors][:message])

diff --git a/publish-gem.sh b/publish-gem.sh
diff --git a/zuora.gemspec b/zuora.gemspec
@@ -21,10 +21,8 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files = ['README.md']
 
   s.add_development_dependency 'appraisal'
-
   s.add_development_dependency 'artifice', '~> 0.6.0'
-  # s.add_development_dependency 'bigdecimal', '< 2.0.0'
-  s.add_development_dependency 'factory_bot'#, '~> 2.6.4'
+  s.add_development_dependency 'factory_bot'
   s.add_development_dependency 'guard-rspec', '~> 0.6.0'
   s.add_development_dependency 'pry'
   s.add_development_dependency 'pry-byebug'
@@ -33,18 +31,14 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'redcarpet', '~> 2.1.0'
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'simplecov', '~> 0.22.0'
-  # s.add_development_dependency 'sqlite3', '~> 1.3.0'
   s.add_development_dependency 'test-unit'
   s.add_development_dependency 'yard', '~> 0.7.5'
-
-  s.add_dependency 'activemodel'#, '< 5.0.0'
- # s.add_dependency 'activesupport', '< 5.0.0'
+  s.add_dependency 'activemodel'
+  s.add_dependency 'akami', '~> 1.3.2'
   s.add_dependency 'httpi', '~> 3.0'
-  s.add_dependency 'rack', '< 3.0'
   s.add_dependency 'libxml4r', '~> 0.2.6'
-  s.add_dependency 'savon', '~> 2.0'
-
-  s.add_dependency 'akami', '~> 1.3.2'
   s.add_dependency 'nokogiri', '~> 1.15.6'
+  s.add_dependency 'rack', '< 3.0'
+  s.add_dependency 'savon', '~> 2.0'
   s.add_dependency 'wasabi', '~> 3.0'
 end