Fix script manager lock key #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysql_framework depends on `redlock`, without any version restriction. However, starting with 2.0.0, `redlock` changed its implementation to use the gem `redis-client`, which does not allow passing in a `Class` type as a locking key. This commit addresses this by using the class name instead. The previous `redis` implementation was calling `#to_s` on the argument, so the end result is the same.
|
Code Climate has analyzed commit eaf97fa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
mob1970
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mysql_framework depends on
redlock, without any version restriction.However, starting with 2.0.0,
redlockchanged its implementation to use the gemredis-client, which does not allow passing in aClasstype as a locking key.This commit addresses this by using the class name instead. The previous
redisimplementation was calling#to_son the argument, so the end result is the same.Relevant links