Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift Package Manager #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ikait
Copy link

@ikait ikait commented Feb 14, 2020

This PR take over #37.

@kondratk
Copy link

Hey, it's stuck here for a while. Any idea when this PR is going to be merged?

@mRs-
Copy link
Member

mRs- commented May 14, 2020

I will have a look into this in the next couple of days

Package.swift Outdated
let package = Package(
name: "RxWebKit",
platforms: [
.iOS(.v8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a specific need (such as APIs used), it's best to leave this unspecified so that SwiftPM can set the minimum platform version to that which is supported by the toolchain.

This is especially important in the era of Xcode 12, as it drops support for iOS 8, making this package unusable with Xcode 12.

@Mordil
Copy link

Mordil commented Oct 17, 2020

@mRs- Were you able to take a look at this? It's now October, and we're wanting to use this library with SwiftPM without forking (even though this library is extremely stable and doesn't see frequent changes)

@Mordil
Copy link

Mordil commented Feb 25, 2021

@mRs- pinging you again, can we get a review on this?

@Mattijah
Copy link

Mattijah commented Nov 1, 2021

Another ping. 2+ years needed in order to add a SPM support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants