Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated method livechat:sendOfflineMessage #33452

Open
wants to merge 1 commit into
base: release-7.0.0
Choose a base branch
from

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 4, 2024

Proposed changes (including videos or screenshots)

Removed deprecated method livechat:sendOfflineMessage. Moving forward, use the endpoint livechat/offline.message.
All added the rate limiter which was present in the method, but was missing in the endpoint.

Issue(s)

Steps to test or reproduce

Further comments

CORE-376

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 4, 2024
@abhinavkrin abhinavkrin requested a review from a team as a code owner October 4, 2024 09:10
Copy link
Contributor

dionisio-bot bot commented Oct 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 8b19bbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33452/
on branch gh-pages at 2024-10-04 09:17 UTC

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (b0364b5) to head (8b19bbf).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33452      +/-   ##
=================================================
- Coverage          75.66%   75.32%   -0.34%     
=================================================
  Files                430      383      -47     
  Lines              19904    19383     -521     
  Branches            5079     4980      -99     
=================================================
- Hits               15060    14601     -459     
+ Misses              4273     4212      -61     
+ Partials             571      570       -1     
Flag Coverage Δ
unit 75.32% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant