Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Event Alert close button #77 #108

Closed
wants to merge 1 commit into from

Conversation

Aashray446
Copy link
Contributor

  • Add toggle state function to close custom toast
  • Add a close prop to the custom toast
    pr-7

 * Add toogle state function to close custom toast
 * Add close prop the the custom toast
@Aashray446
Copy link
Contributor Author

@Dnouv I have created this pull request for issue #77, as most TODO are around those pages and components, it's a little bit annoying while testing and creating an Event.
Also, this issue was there for so long and inactive so I raised the PR without being assigned, I apologize for this.

Thank you!

@SarveshLimaye
Copy link
Contributor

@Aashray446 Thank you for the pr. We need to create a new component that displays alerts in the top right corner similar to one in Rocket chat. I was too busy working on other pr and did not update the title of the issue. Currently, I am working on this issue. You can look up to other open issues and work on them.

@Aashray446
Copy link
Contributor Author

Oh ok that's great. Sorry , I thought there is no activity in this issue so I solved

Thanks 🙏

@Aashray446 Aashray446 closed this Jan 30, 2023
@Aashray446 Aashray446 deleted the fixCloseButton branch January 30, 2023 00:23
@Dnouv
Copy link
Member

Dnouv commented Jan 31, 2023

Thank you, @SarveshLimaye, for making things clear. And thanks for the hard work on the PR @Aashray446; we really appreciate your time and dedication; this is the case that I was worried about if someone opened up a PR without explaining the issue. I would add it to the contribution guideline so that others' time won't be wasted.

I apologize for the inconvenience, and thank you once again, @Aashray446 . Since you have been so active in RC4Conferences, it would be good if you can open up any new feature requests that you think would be a good addition.

@Aashray446
Copy link
Contributor Author

Thanks, @Dnouv for the recognization and for believing in me. Currently, I am looking forward to implementing the new text area component as it will be used in many places in the future, and contributing a component to the project make me feel a little proud 😅

I have mentioned the library choices for making that component in issue #105, Waiting for your valuable suggestion
Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants