-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deploy ERC20TransferableReceivable to Sepolia #1418
Merged
MantisClone
merged 3 commits into
master
from
deploy-erc20-transferable-receivable-on-sepolia
Jun 28, 2024
Merged
chore: deploy ERC20TransferableReceivable to Sepolia #1418
MantisClone
merged 3 commits into
master
from
deploy-erc20-transferable-receivable-on-sepolia
Jun 28, 2024
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
kevindavee,
sstefdev and
yomarion
June 27, 2024 00:55
Build is blocked by #1417 (comment) |
alexandre-abrioux
approved these changes
Jun 27, 2024
Co-authored-by: Alexandre ABRIOUX <[email protected]>
I am merging with partial review because Request Network Summer Hackathon hackers need it. I tested it locally using https://github.com/RequestNetwork/quickstart-node-js and Error before changes
npm run create
> [email protected] create
> node src/createRequest.js
/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/payment-detection/dist/utils.js:63
throw new balance_error_1.NetworkNotSupported(`Network not supported for this payment network: ${network}`);
^
NetworkNotSupported [Error]: Network not supported for this payment network: sepolia
at ERC20TransferableReceivablePaymentDetector.getDeploymentInformation (/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/pa
yment-detection/dist/utils.js:63:23) at PaymentNetworkFactory.createPaymentNetwork (/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/payment-detection/dist/paym
ent-network-factory.js:112:27) at HttpRequestNetwork.<anonymous> (/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/request-client.js/dist/api/request-netw
ork.js:257:46) at Generator.next (<anonymous>)
at /home/mantisclone/projects/quickstart-node-js/node_modules/tslib/tslib.js:167:75
at new Promise (<anonymous>)
at Object.__awaiter (/home/mantisclone/projects/quickstart-node-js/node_modules/tslib/tslib.js:163:16)
at HttpRequestNetwork.prepareRequestParameters (/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/request-client.js/dist/api
/request-network.js:241:24) at HttpRequestNetwork.<anonymous> (/home/mantisclone/projects/quickstart-node-js/node_modules/@requestnetwork/request-client.js/dist/api/request-netw
ork.js:40:78) at Generator.next (<anonymous>) {
code: 2
}
Node.js v18.17.1
Success after changes
npm run create
> [email protected] create
> node src/createRequest.js
{"_events":{},"_eventsCount":0,"currency":"FAU-sepolia","expectedAmount":"1000000000000000000","payee":{"type":"ethereumAddress","value":"0x7eB023BFbAeE2
28de6DC5B92D0BeEB1eDb1Fd567"},"payer":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"timestamp":1719538977,"extensionsData":[{"action":"create","id":"pn-erc20-transferable-receivable","parameters":{"feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","paymentNetworkName":"sepolia","salt":"6137e13aeba5d6c3"},"version":"0.2.0"},{"action":"create","id":"content-data","parameters":{"content":{"reason":"🍕","dueDate":"2023.06.16"}},"version":"0.1.0"}],"extensions":{"pn-erc20-transferable-receivable":{"events":[{"name":"create","parameters":{"feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","salt":"6137e13aeba5d6c3"},"timestamp":1719538992}],"id":"pn-erc20-transferable-receivable","type":"payment-network","values":{"salt":"6137e13aeba5d6c3","receivedPaymentAmount":"0","receivedRefundAmount":"0","sentPaymentAmount":"0","sentRefundAmount":"0","paymentAddress":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567","feeAddress":"0x0000000000000000000000000000000000000000","feeAmount":"0","feeBalance":{"events":[],"balance":"0"}},"version":"0.2.0"},"content-data":{"events":[],"id":"content-data","type":"content-data","values":{"content":{"reason":"🍕","dueDate":"2023.06.16"}},"version":"0.1.0"}},"requestId":"0100f79bafe395c347d1f72a04d0c3855bfe1b8c3a200f168399048e4f8b61a984","version":"2.0.3","events":[{"actionSigner":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"name":"create","parameters":{"expectedAmount":"1000000000000000000","extensionsDataLength":2,"isSignedRequest":false},"timestamp":1719538992}],"state":"created","creator":{"type":"ethereumAddress","value":"0x7eB023BFbAeE228de6DC5B92D0BeEB1eDb1Fd567"},"balance":{"balance":"0","events":[],"escrowEvents":[]},"contentData":{"reason":"🍕","dueDate":"2023.06.16"},"currencyInfo":{"type":"ERC20","value":"0x370DE27fdb7D1Ff1e1BaA7D11c5820a324Cf623C","network":"sepolia"},"meta":{"ignoredTransactions":[],"transactionManagerMeta":{"dataAccessMeta":{"transactionsStorageLocation":["QmVNRvTdaG1EzSXDqgpbgQWxAdxqjmzDE7W5k9yfkixnd7"],"storageMeta":[{"ethereum":{"blockConfirmation":0,"blockNumber":6201827,"blockTimestamp":1719538992,"networkName":"sepolia","smartContractAddress":"0xd6c085a4d14e9e171f4af58f7f48bd81173f167e","transactionHash":"0xe44489d7e9e10c0964274b9ada71c0370d7e5c66549f03a28eeace5f6468993c"},"ipfs":{"size":1567},"state":"confirmed","storageType":"ethereumIpfs","timestamp":1719538992}]},"ignoredTransactions":[null]}},"pending":null} |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1416
Description of the changes
https://sepolia.etherscan.io/address/0xB5E53C3d145Cbaa61C7028736A1fF0bC6817A4c5#code
Console Log