Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: (for discussion) add topics to accept #1192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vrolland
Copy link
Contributor

@vrolland vrolland commented Oct 8, 2023

Description of the changes

Give the opportunity to add topics when accepting a request.

⚠️ This is only for discussion purpose. ⚠️

@MantisClone
Copy link
Member

MantisClone commented Oct 8, 2023

Some questions:

  • What use case does this feature serve?
    • This idea was motivated by a hacker at ETHRome who wanted to retrieve and filter requests by an arbitrary identifier. They gave the example of wanting to see all requests that are television purchases.
    • They wanted to apply these arbitrary identifiers to existing requests.
  • Should all actions allow adding topics?
    • I don't see a problem with this.
  • Should there be an addTopic() action in case someone only wants to add a topic without performing some other action?
    • If we implemented this feature, I think addTopic() would be a necessary part of it.
  • Does there need to be some sort of consensus between payer and payee to add a topic?
    • Honest question. I'm leaning towards no, but I'm not sure of the implications.
  • Can any stakeholder add a topic?
    • Honest question. I'm leaning towards yes, but I'm not sure of the implications.

@MantisClone
Copy link
Member

@vrolland Sorry this fell through the cracks. I just added it to the Request Network Tech Backlog and we'll be able to assign priority to this task at our next backlog refinement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✨ Backlog: Enhancements
Development

Successfully merging this pull request may close these issues.

2 participants