chore: support 'near' aside 'aurora' #1059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
kevindavee,
leoslr,
olivier7delf and
yomarion
benjlevesque
approved these changes
Feb 8, 2023
olivier7delf
approved these changes
Feb 13, 2023
yomarion
reviewed
Mar 27, 2023
There was a problem hiding this comment.
I don't know how up-to-date this PR is, but when working on #1086 , I thought it'd be handy to define aurora and aurora-testnet as a +/- CurrencyTypes.AliasFor<NearChains>, so we can little-by-little reduce the aurora compatibility surface to storage reading, and even deprecate that.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #956