refactor: rename updateEthereumFeeProxy to setEthereumFeeProxy for cl…

…arity in SingleRequestProxyFactory contract
RequestNetwork · Sep 23, 2024 · 0c68eba · 0c68eba
1 parent aab6711
commit 0c68eba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/smart-contracts/src/contracts/SingleRequestProxyFactory.sol b/packages/smart-contracts/src/contracts/SingleRequestProxyFactory.sol
@@ -97,7 +97,7 @@ contract SingleRequestProxyFactory is Ownable {
    * @notice Updates the EthereumFeeProxy address
    * @param _newEthereumFeeProxy The new EthereumFeeProxy address
    */
-  function updateEthereumFeeProxy(address _newEthereumFeeProxy) external onlyOwner {
+  function setEthereumFeeProxy(address _newEthereumFeeProxy) external onlyOwner {
     ethereumFeeProxy = _newEthereumFeeProxy;
   }
 }
diff --git a/packages/smart-contracts/test/contracts/SingleRequestProxyFactory.test.ts b/packages/smart-contracts/test/contracts/SingleRequestProxyFactory.test.ts
@@ -158,7 +158,7 @@ describe('contract: SingleRequestProxyFactory', () => {
     ).deploy();
     await newEthereumFeeProxy.deployed();
 
-    await singleRequestProxyFactory.updateEthereumFeeProxy(newEthereumFeeProxy.address);
+    await singleRequestProxyFactory.setEthereumFeeProxy(newEthereumFeeProxy.address);
     expect(await singleRequestProxyFactory.ethereumFeeProxy()).to.equal(
       newEthereumFeeProxy.address,
     );
@@ -170,7 +170,7 @@ describe('contract: SingleRequestProxyFactory', () => {
       await newEthereumFeeProxy.deployed();
 
       await expect(
-        singleRequestProxyFactory.connect(user).updateEthereumFeeProxy(newEthereumFeeProxy.address),
+        singleRequestProxyFactory.connect(user).setEthereumFeeProxy(newEthereumFeeProxy.address),
       ).to.be.revertedWith('Ownable: caller is not the owner');
     });
   });