Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env vars for configuring payments subgraph URLs #41

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

MantisClone
Copy link
Member

@MantisClone MantisClone commented Jun 27, 2024

Problem

The rate-limit on the free subgraph URLs from Subgraph Studio is lower than expected. The net effect is that Request Payment (https://invoicing.request.network/) will often (but not always) fail to detect that a request is paid.

  • When making a payment, the UI will often tell you the payment failed, even though the transaction went through.
  • When displaying the dashboard, paid requests would often display "created" status instead of the expected "paid" status.

Bandaid Solution

Get paid URLs from Subgraph Studio.

Changes

  • feat: add NEXT_PUBLIC_PAYMENT_SUBGRAPH_URL_... env vars and getSubgraphClient() function for configuring payments subgraph URLs

Screenshots

This screenshot shows the "paid" status indicator on the invoice details drawer
2024-06-27_18-29

This screenshot shows the "paid" status indicator on the invoice dashboard
2024-06-27_18-28

Context

@MantisClone MantisClone marked this pull request as ready for review June 27, 2024 23:02
@MantisClone
Copy link
Member Author

Merging without review to fix production Request Payments (https://invoicing.request.network)

@MantisClone MantisClone merged commit bc1276e into main Jun 27, 2024
@MantisClone MantisClone deleted the use-paid-subgraph-studio-urls branch June 27, 2024 23:18
@MantisClone MantisClone added this to the Invoicing Template V2 milestone Jun 28, 2024
@MantisClone MantisClone self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant