Extend profile to work for mysql #1575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I keep forgetting why we haven't merged this. My biggest fear is that this PR sets a new default for new installs and we don't have enough data points from production use of MySQL + JSON + RES. |
Since mysql supports json format now, profile should take that into consideration and generate JSONClient instead of regular one.
fidel
force-pushed
the
mysql_json_profile
branch
from
b6367e2
to
94a75c9
Compare
fidel
force-pushed
the
mysql_json_profile
branch
from
b5023de
to
9873ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mysql supports json format now, profile should take that into consideration and generate JSONClient instead of regular one.
Should be merged once we agree that JSONClient is a good default for MySQL with json columns