Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't construct Embed{}s for 1x1 filters in convolutions #1669

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Don't construct Embed{}s for 1x1 filters in convolutions

d82d211
Select commit
Loading
Failed to load commit list.
Open

Don't construct Embed{}s for 1x1 filters in convolutions #1669

Don't construct Embed{}s for 1x1 filters in convolutions
d82d211
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 4, 2024 in 0s

67.85% of diff hit (target 83.69%)

View this Pull Request on Codecov

67.85% of diff hit (target 83.69%)

Annotations

Check warning on line 630 in mlir/lib/Dialect/Rock/IR/TransformMapBuilder.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

mlir/lib/Dialect/Rock/IR/TransformMapBuilder.cpp#L628-L630

Added lines #L628 - L630 were not covered by tests

Check warning on line 685 in mlir/lib/Dialect/Rock/Transforms/ConvToGemm.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

mlir/lib/Dialect/Rock/Transforms/ConvToGemm.cpp#L684-L685

Added lines #L684 - L685 were not covered by tests